]> git.baikalelectronics.ru Git - kernel.git/commit
video: fbdev: vt8623fb: Error out if 'pixclock' equals zero
authorZheyu Ma <zheyuma97@gmail.com>
Mon, 4 Apr 2022 08:47:20 +0000 (16:47 +0800)
committerHelge Deller <deller@gmx.de>
Mon, 11 Apr 2022 06:23:49 +0000 (08:23 +0200)
commit8dd0d7d5bd6651ab27e1247d8d4fa7e2b0c951df
treeb5d0f0f5490e1329921d764080ada0b60e3c4322
parentf9b8569b24ea97b59a7e72b617312a1a874b0d04
video: fbdev: vt8623fb: Error out if 'pixclock' equals zero

The userspace program could pass any values to the driver through
ioctl() interface. If the driver doesn't check the value of 'pixclock',
it may cause divide error.

Fix this by checking whether 'pixclock' is zero in the function
vt8623fb_check_var().

The following log reveals it:
 divide error: 0000 [#1] PREEMPT SMP KASAN PTI
 RIP: 0010:vt8623fb_set_par+0xecd/0x2210
 Call Trace:
  <TASK>
  fb_set_var+0x604/0xeb0
  do_fb_ioctl+0x234/0x670
  fb_ioctl+0xdd/0x130
  do_syscall_64+0x3b/0x90

Signed-off-by: Zheyu Ma <zheyuma97@gmail.com>
Signed-off-by: Helge Deller <deller@gmx.de>
drivers/video/fbdev/vt8623fb.c