]> git.baikalelectronics.ru Git - kernel.git/commit
clk: Return errors from clk providers in __of_clk_get_from_provider()
authorStephen Boyd <sboyd@codeaurora.org>
Mon, 15 Aug 2016 21:32:23 +0000 (14:32 -0700)
committerStephen Boyd <sboyd@codeaurora.org>
Mon, 15 Aug 2016 21:32:23 +0000 (14:32 -0700)
commit8d98fc50ee86561c824603e33eb060aa038846dd
tree5e274853713d1e438f2e49d4c9e9578132ac72b6
parente625f8a778edef99f666c9c0141003bf024f67b1
clk: Return errors from clk providers in __of_clk_get_from_provider()

Before commit a97ff55d24aa (clk: Add clk_hw OF clk providers,
2016-02-05) __of_clk_get_from_provider() would return an error
pointer of the provider's choosing if there was a provider
registered and EPROBE_DEFER otherwise. After that commit, it
would return EPROBE_DEFER regardless of whether or not the
provider returned an error. This is odd and can lead to behavior
where clk consumers keep probe deferring when they should be
seeing some other error.

Let's restore the previous behavior where we only return
EPROBE_DEFER when there isn't a provider in our of_clk_providers
list. Otherwise, return the error from the last provider we find
that matches the node.

Reported-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Fixes: a97ff55d24aa ("clk: Add clk_hw OF clk providers")
Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
drivers/clk/clk.c