]> git.baikalelectronics.ru Git - kernel.git/commit
net: dsa: b53: fix an off by one in checking "vlan->vid"
authorDan Carpenter <dan.carpenter@oracle.com>
Tue, 19 Jan 2021 14:48:03 +0000 (17:48 +0300)
committerJakub Kicinski <kuba@kernel.org>
Wed, 20 Jan 2021 03:34:49 +0000 (19:34 -0800)
commit8d28f2bb5dc54ec1fe1f529b551488b3164e7fdd
tree716a26084f94a0594cbb8736ee9cbd221f8ee904
parentb88ca56efff3a1c18be5b8603b42e8f24e5a53c0
net: dsa: b53: fix an off by one in checking "vlan->vid"

The > comparison should be >= to prevent accessing one element beyond
the end of the dev->vlans[] array in the caller function, b53_vlan_add().
The "dev->vlans" array is allocated in the b53_switch_init() function
and it has "dev->num_vlans" elements.

Fixes: c8215488b3e2 ("net: dsa: b53: Plug in VLAN support")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
Link: https://lore.kernel.org/r/YAbxI97Dl/pmBy5V@mwanda
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/dsa/b53/b53_common.c