]> git.baikalelectronics.ru Git - kernel.git/commit
perf kcore_copy: Do not check /proc/modules is unchanged
authorAdrian Hunter <adrian.hunter@intel.com>
Wed, 14 Sep 2022 12:24:29 +0000 (15:24 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 28 Sep 2022 09:04:07 +0000 (11:04 +0200)
commit8d141f1420994d1f83af9e6a0ea7b22f74f63998
tree2a2e6a89d3c0679c5391e267b906762605d2686d
parenta39518dcb7ea7d038e4283f4a9ada6d56b5f6a05
perf kcore_copy: Do not check /proc/modules is unchanged

[ Upstream commit 4b98e6d43c1a39515362b93632b2093ddaa5baa5 ]

/proc/kallsyms and /proc/modules are compared before and after the copy
in order to ensure no changes during the copy.

However /proc/modules also might change due to reference counts changing
even though that does not make any difference.

Any modules loaded or unloaded should be visible in changes to kallsyms,
so it is not necessary to check /proc/modules also anyway.

Remove the comparison checking that /proc/modules is unchanged.

Fixes: 222e11096bd6357f ("perf buildid-cache: Add ability to add kcore to the cache")
Reported-by: Daniel Dao <dqminh@cloudflare.com>
Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
Tested-by: Daniel Dao <dqminh@cloudflare.com>
Acked-by: Namhyung Kim <namhyung@kernel.org>
Cc: Ian Rogers <irogers@google.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Link: https://lore.kernel.org/r/20220914122429.8770-1-adrian.hunter@intel.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
tools/perf/util/symbol-elf.c