]> git.baikalelectronics.ru Git - kernel.git/commit
gfs2: Always check inode size of inline inodes
authorAndreas Gruenbacher <agruenba@redhat.com>
Sun, 4 Dec 2022 16:00:04 +0000 (17:00 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 5 Apr 2023 09:16:46 +0000 (11:16 +0200)
commit8c639f7e914196897ba3213a76268ab55c3b29be
tree2838befcc77ca71f9a7abdb2a10506f28529239b
parent99105888dfc59ecde7445b60e6f493d719ea86a3
gfs2: Always check inode size of inline inodes

commit 70376c7ff31221f1d21db5611d8209e677781d3a upstream.

Check if the inode size of stuffed (inline) inodes is within the allowed
range when reading inodes from disk (gfs2_dinode_in()).  This prevents
us from on-disk corruption.

The two checks in stuffed_readpage() and gfs2_unstuffer_page() that just
truncate inline data to the maximum allowed size don't actually make
sense, and they can be removed now as well.

Reported-by: syzbot+7bb81dfa9cda07d9cd9d@syzkaller.appspotmail.com
Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com>
[pchelkin@ispras.ru: adjust the inode variable inside gfs2_dinode_in with
the format used before upstream commit 7db354444ad8 ("gfs2: Cosmetic
gfs2_dinode_{in,out} cleanup")]
Signed-off-by: Fedor Pchelkin <pchelkin@ispras.ru>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
fs/gfs2/aops.c
fs/gfs2/bmap.c
fs/gfs2/glops.c