]> git.baikalelectronics.ru Git - kernel.git/commit
virtio-pci: Remove wrong address verification in vp_del_vqs()
authorMurilo Opsfelder Araujo <muriloo@linux.ibm.com>
Fri, 15 Apr 2022 02:30:02 +0000 (23:30 -0300)
committerMichael S. Tsirkin <mst@redhat.com>
Tue, 31 May 2022 16:45:08 +0000 (12:45 -0400)
commit8c54f2534cfa3f991e14e3b3f6d6b3c5d5141658
treedcbf07eac881c503ed2582d5645bfa506c8fe837
parenta0594616bc3f80ce9e169984134a276edd8d5558
virtio-pci: Remove wrong address verification in vp_del_vqs()

GCC 12 enhanced -Waddress when comparing array address to null [0],
which warns:

    drivers/virtio/virtio_pci_common.c: In function ‘vp_del_vqs’:
    drivers/virtio/virtio_pci_common.c:257:29: warning: the comparison will always evaluate as ‘true’ for the pointer operand in ‘vp_dev->msix_affinity_masks + (sizetype)((long unsigned int)i * 256)’ must not be NULL [-Waddress]
      257 |                         if (vp_dev->msix_affinity_masks[i])
          |                             ^~~~~~

In fact, the verification is comparing the result of a pointer
arithmetic, the address "msix_affinity_masks + i", which will always
evaluate to true.

Under the hood, free_cpumask_var() calls kfree(), which is safe to pass
NULL, not requiring non-null verification.  So remove the verification
to make compiler happy (happy compiler, happy life).

[0] https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102103

Signed-off-by: Murilo Opsfelder Araujo <muriloo@linux.ibm.com>
Message-Id: <20220415023002.49805-1-muriloo@linux.ibm.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Acked-by: Christophe de Dinechin <dinechin@redhat.com>
drivers/virtio/virtio_pci_common.c