]> git.baikalelectronics.ru Git - kernel.git/commit
net: mdiobus: fix double put fwnode in the error path
authorYang Yingliang <yangyingliang@huawei.com>
Fri, 2 Dec 2022 05:18:33 +0000 (13:18 +0800)
committerDavid S. Miller <davem@davemloft.net>
Mon, 5 Dec 2022 11:00:25 +0000 (11:00 +0000)
commit8be2a8bdd8c09dd6e832c61f468a201c9b7df5b0
tree3d73d27ba5971040d2d7712e72f1ce2faed99b4a
parent1a382882e5ca694c1cb96fa8284298186d539a27
net: mdiobus: fix double put fwnode in the error path

If phy_device_register() or fwnode_mdiobus_phy_device_register()
fail, phy_device_free() is called, the device refcount is decreased
to 0, then fwnode_handle_put() will be called in phy_device_release(),
but in the error path, fwnode_handle_put() has already been called,
so set fwnode to NULL after fwnode_handle_put() in the error path to
avoid double put.

Fixes: 4833600acd84 ("net: mdiobus: fix unbalanced node reference count")
Reported-by: Zeng Heng <zengheng4@huawei.com>
Tested-by: Zeng Heng <zengheng4@huawei.com>
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Reviewed-by: Zeng Heng <zengheng4@huawei.com>
Tested-by: Zeng Heng <zengheng4@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/mdio/fwnode_mdio.c