]> git.baikalelectronics.ru Git - kernel.git/commit
drivers/ide/{cs5530.c,sc1200.c}: Move a dereference below a NULL test
authorJulia Lawall <julia@diku.dk>
Mon, 22 Dec 2008 22:05:06 +0000 (23:05 +0100)
committerBartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Mon, 22 Dec 2008 22:05:06 +0000 (23:05 +0100)
commit8bb327a7bfc721bd024f827a68a7e44b065ec6c0
treebcf788b943c0050b06a30f69a940ae31fd69c6bf
parent3baa3bd5cd9f70c594e32b65d91429af6323ffd6
drivers/ide/{cs5530.c,sc1200.c}: Move a dereference below a NULL test

In each case, if the NULL test is necessary, then the dereference should be
moved below the NULL test.

The semantic patch that makes this change is as follows:
(http://www.emn.fr/x-info/coccinelle/)

// <smpl>
@@
type T;
expression E;
identifier i,fld;
statement S;
@@

- T i = E->fld;
+ T i;
  ... when != E
      when != i
  if (E == NULL) S
+ i = E->fld;
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Acked-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
drivers/ide/cs5530.c
drivers/ide/sc1200.c