]> git.baikalelectronics.ru Git - kernel.git/commit
block: fix missing queue put in error path
authorJens Axboe <axboe@kernel.dk>
Mon, 15 Nov 2021 21:23:08 +0000 (14:23 -0700)
committerJens Axboe <axboe@kernel.dk>
Tue, 16 Nov 2021 00:00:54 +0000 (17:00 -0700)
commit8b7d6f7650c06ecec825d0aa862e2c1f586ddb2c
treea9af8b4f82ad0afa875748aac6be944709158ef4
parent0269c48c8fd819488c033870e1e4e3ccbdf6ef58
block: fix missing queue put in error path

If we fail the submission queue checks, we don't put the queue afterwards.
This can cause various issues like stalls on scheduler switch or failure
to remove the device, or like in the original bug report, timeout waiting
for the device on reboot/restart.

While in there, fix a few whitespace discrepancies in the surrounding
code.

Link: https://bugzilla.kernel.org/show_bug.cgi?id=215039
Fixes: bedac8e909b0 ("blk-mq: fix filesystem I/O request allocation")
Reported-and-tested-by: Stephen Smith <stephenmsmith@blueyonder.co.uk>
Reviewed-by: Ming Lei <ming.lei@redhat.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
block/blk-mq.c