]> git.baikalelectronics.ru Git - kernel.git/commit
nbd: Fix hung on disconnect request if socket is closed before
authorXie Yongji <xieyongji@bytedance.com>
Tue, 22 Mar 2022 08:06:39 +0000 (16:06 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 9 Jun 2022 08:22:38 +0000 (10:22 +0200)
commit8b50672886d769b0d5af6b03b8a1c088940acae1
tree640136ec7563cbf120ea314979ff9ed0c0ebde63
parent16eca12d974473424f103ca7e31bb21a8da06f06
nbd: Fix hung on disconnect request if socket is closed before

[ Upstream commit 25026250301bd2e7121997ff4a234e8443275bd8 ]

When userspace closes the socket before sending a disconnect
request, the following I/O requests will be blocked in
wait_for_reconnect() until dead timeout. This will cause the
following disconnect request also hung on blk_mq_quiesce_queue().
That means we have no way to disconnect a nbd device if there
are some I/O requests waiting for reconnecting until dead timeout.
It's not expected. So let's wake up the thread waiting for
reconnecting directly when a disconnect request is sent.

Reported-by: Xu Jianhai <zero.xu@bytedance.com>
Signed-off-by: Xie Yongji <xieyongji@bytedance.com>
Reviewed-by: Josef Bacik <josef@toxicpanda.com>
Link: https://lore.kernel.org/r/20220322080639.142-1-xieyongji@bytedance.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/block/nbd.c