]> git.baikalelectronics.ru Git - kernel.git/commit
serial: 8250_dw: fix wrong logic in dw8250_check_lcr()
authorKefeng Wang <wangkefeng.wang@huawei.com>
Mon, 2 May 2016 09:19:46 +0000 (17:19 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 3 May 2016 23:10:38 +0000 (16:10 -0700)
commit8aebc0329bc1da831eeabd2eff0be74e9dd76d17
tree8240bfbc4d568e9095eeb316d56eaf1e47ffd857
parentf34e5e2eeee0db8ed3e8ebba850259d2691ffa7c
serial: 8250_dw: fix wrong logic in dw8250_check_lcr()

Commit 356c6ed56331 ("serial: 8250_dw: Avoid serial_outx code duplicate
with new dw8250_check_lcr()") introduce a wrong logic when write val to
LCR reg. When CONFIG_64BIT enabled, __raw_writeq is used unconditionally.

The __raw_readq/__raw_writeq is introduced by commit 9ec740ec8c5b ("serial:
8250_dw: Use 64-bit access for OCTEON.") for OCTEON.

So for 64BIT && !PORT_OCTEON, we better to use coincident write function.

Fixes: 356c6ed56331("serial: 8250_dw: Avoid serial_outx code duplicate with new dw8250_check_lcr()")
Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/serial/8250/8250_dw.c