]> git.baikalelectronics.ru Git - kernel.git/commit
xfs: prevent leaking uninitialized stack memory in FSGEOMETRY_V1
authorDan Rosenberg <drosenberg@vsecurity.com>
Mon, 14 Feb 2011 13:45:28 +0000 (13:45 +0000)
committerAlex Elder <aelder@sgi.com>
Tue, 22 Feb 2011 21:06:47 +0000 (15:06 -0600)
commit8a7c0847c2620277dc7245d17c01e33279817f3b
treeca218171c9493272b40a4bb9c9a2099ba1240a47
parent742ffcaca9663bd1a8326711129b4f27acbfd34e
xfs: prevent leaking uninitialized stack memory in FSGEOMETRY_V1

The FSGEOMETRY_V1 ioctl (and its compat equivalent) calls out to
xfs_fs_geometry() with a version number of 3.  This code path does not
fill in the logsunit member of the passed xfs_fsop_geom_t, leading to
the leaking of four bytes of uninitialized stack data to potentially
unprivileged callers.

v2 switches to memset() to avoid future issues if structure members
change, on suggestion of Dave Chinner.

Signed-off-by: Dan Rosenberg <drosenberg@vsecurity.com>
Reviewed-by: Eugene Teo <eugeneteo@kernel.org>
Signed-off-by: Alex Elder <aelder@sgi.com>
fs/xfs/xfs_fsops.c