]> git.baikalelectronics.ru Git - kernel.git/commit
rtc: rtc-rs5c313: Fix late hardware init
authorGeert Uytterhoeven <geert+renesas@glider.be>
Fri, 14 Aug 2020 11:07:30 +0000 (13:07 +0200)
committerAlexandre Belloni <alexandre.belloni@bootlin.com>
Thu, 20 Aug 2020 22:13:44 +0000 (00:13 +0200)
commit8a10e912ba3ca22457ef5cf5005f0464ed8e9d77
tree6888ab3c2489bdb86fb23cdf8df2ec9e2cee891f
parent41f700ed79f2f5006f3849f7c2017d1968173d1a
rtc: rtc-rs5c313: Fix late hardware init

rs5c313_rtc_init() calls platform_driver_register(), and initializes the
hardware.  This is wrong because of two reasons:
  1. As soon as the driver has been registered, the device may be
     probed.  If devm_rtc_device_register() is called before hardware
     initialization, reading the current time will fail:

rs5c313 rs5c313: rs5c313_rtc_read_time: timeout error
rs5c313 rs5c313: registered as rtc0
rs5c313 rs5c313: rs5c313_rtc_read_time: timeout error
rs5c313 rs5c313: hctosys: unable to read the hardware clock

  2. If the platform device does not exist, the driver will still write
     to a hardware device that may not be present.

Fix this by moving the hardware initialization sequence to the driver's
.probe() method.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Link: https://lore.kernel.org/r/20200814110731.29029-3-geert+renesas@glider.be
drivers/rtc/rtc-rs5c313.c