]> git.baikalelectronics.ru Git - kernel.git/commit
fec: Remove fec_enet_select_queue()
authorFabio Estevam <fabio.estevam@freescale.com>
Mon, 22 Sep 2014 20:55:29 +0000 (17:55 -0300)
committerDavid S. Miller <davem@davemloft.net>
Fri, 26 Sep 2014 19:39:59 +0000 (15:39 -0400)
commit89ffa843c7dd7848f68f59d7dee357b1d904e882
treeee80643e5dd8e156ad23b492874f5409cd44f1e9
parentc9fb09277ce687a215ecc8516f87a2ce2f0d55c3
fec: Remove fec_enet_select_queue()

Sparse complains about fec_enet_select_queue() not being static.

Feedback from David Miller [1] was to remove this function instead of making it
static:

"Please just delete this function.

It's overriding code which does exactly the same thing.

Actually, more precisely, this code is duplicating code in a way that
bypasses many core facilitites of the networking.  For example, this
override means that socket based flow steering, XPS, etc. are all
not happening on these devices.

Without ->ndo_select_queue(), the flow dissector does __netdev_pick_tx
which is exactly what you want to happen."

[1] http://www.spinics.net/lists/netdev/msg297653.html

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/freescale/fec_main.c