]> git.baikalelectronics.ru Git - kernel.git/commit
drm/i915/fbc: Remember to update FBC state even when not reallocating CFB
authorVille Syrjälä <ville.syrjala@linux.intel.com>
Thu, 16 Dec 2021 11:08:22 +0000 (13:08 +0200)
committerVille Syrjälä <ville.syrjala@linux.intel.com>
Thu, 23 Dec 2021 12:06:32 +0000 (14:06 +0200)
commit89db66c74a87c7237c70229a97f61163f562400e
tree0941f832437682a2e7f0dee490a9018e5310935c
parenteaa8b509ac1ebda2e849ba50836e7008c8ffd48f
drm/i915/fbc: Remember to update FBC state even when not reallocating CFB

We mustn't forget to update our FBC state even if we don't have
to reallocate the CFB. Otherwise we won't refresh our notion
of what eg. the new fence or the new override CFB stride
should be. Using the wrong CFB stride in particular can cause
underruns and could even corrupt other stuff in stolen.

Fixes: 79443e67d091 ("drm/i915/fbc: Nuke state_cache")
Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/4774
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20211216110822.8461-1-ville.syrjala@linux.intel.com
Reviewed-by: Mika Kahola <mika.kahola@intel.com>
drivers/gpu/drm/i915/display/intel_fbc.c