]> git.baikalelectronics.ru Git - kernel.git/commit
ALSA: usb-audio: Fix potential memory leaks
authorTakashi Iwai <tiwai@suse.de>
Fri, 30 Sep 2022 10:01:51 +0000 (12:01 +0200)
committerTakashi Iwai <tiwai@suse.de>
Fri, 30 Sep 2022 10:02:54 +0000 (12:02 +0200)
commit89a06a6624a411b6d0e583aa37934b170c0c814a
tree2340b2642debfcd79a4c0139650e07f8826db173
parent230f5de249debf98955270853a664250d5792ba5
ALSA: usb-audio: Fix potential memory leaks

When the driver hits -ENOMEM at allocating a URB or a buffer, it
aborts and goes to the error path that releases the all previously
allocated resources.  However, when -ENOMEM hits at the middle of the
sync EP URB allocation loop, the partially allocated URBs might be
left without released, because ep->nurbs is still zero at that point.

Fix it by setting ep->nurbs at first, so that the error handler loops
over the full URB list.

Cc: <stable@vger.kernel.org>
Link: https://lore.kernel.org/r/20220930100151.19461-1-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/usb/endpoint.c