]> git.baikalelectronics.ru Git - kernel.git/commit
drm/vmwgfx: Fix an invalid read
authorZack Rusin <zackr@vmware.com>
Fri, 18 Mar 2022 17:43:28 +0000 (13:43 -0400)
committerZack Rusin <zackr@vmware.com>
Mon, 21 Mar 2022 14:10:33 +0000 (10:10 -0400)
commit898e2137ea70c2f89c759384f4ba7bec816b86af
tree5fdd5c27a93a1f484eba251ad999ff33a586d684
parent26004c680bc792f58ecfd6e84b18c5e4c0d263a8
drm/vmwgfx: Fix an invalid read

vmw_move assumed that buffers to be moved would always be
vmw_buffer_object's but after introduction of new placement for mob
pages that's no longer the case.
The resulting invalid read didn't have any practical consequences
because the memory isn't used unless the object actually is a
vmw_buffer_object.
Fix it by moving the cast to the spot where the results are used.

Signed-off-by: Zack Rusin <zackr@vmware.com>
Fixes: 52aa8b410c54 ("drm/vmwgfx: Introduce a new placement for MOB page tables")
Reported-by: Chuck Lever III <chuck.lever@oracle.com>
Reviewed-by: Martin Krastev <krastevm@vmware.com>
Tested-by: Chuck Lever <chuck.lever@oracle.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20220318174332.440068-2-zack@kde.org
drivers/gpu/drm/vmwgfx/vmwgfx_resource.c