]> git.baikalelectronics.ru Git - kernel.git/commit
hwmon: (acpi_power_meter) Change log level for 'unsafe software power cap'
authorWang Shenran <shenran268@gmail.com>
Wed, 24 Jul 2019 08:01:10 +0000 (11:01 +0300)
committerGuenter Roeck <linux@roeck-us.net>
Tue, 3 Sep 2019 19:47:17 +0000 (12:47 -0700)
commit88f30f521ff28c6558fa582c8535d666ec4ac44a
tree678184068554c54ab2d7408a4444d4c258e24845
parent45128317b3881eda128f47bf0ac5586a375f0361
hwmon: (acpi_power_meter) Change log level for 'unsafe software power cap'

At boot time, the acpi_power_meter driver logs the following error level
message: "Ignoring unsafe software power cap". Having read about it from
a few sources, it seems that the error message can be quite misleading.

While the message can imply that Linux is ignoring the fact that the
system is operating in potentially dangerous conditions, the truth is
the driver found an ACPI_PMC object that supports software power
capping. The driver simply decides not to use it, perhaps because it
doesn't support the object.

The best solution is probably changing the log level from error to warning.
All sources I have found, regarding the error, have downplayed its
significance. There is not much of a reason for it to be on error level,
while causing potential confusions or misinterpretations.

Signed-off-by: Wang Shenran <shenran268@gmail.com>
Link: https://lore.kernel.org/r/20190724080110.6952-1-shenran268@gmail.com
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
drivers/hwmon/acpi_power_meter.c