]> git.baikalelectronics.ru Git - kernel.git/commit
RDMA/cma: Use output interface for net_dev check
authorHåkon Bugge <haakon.bugge@oracle.com>
Wed, 12 Oct 2022 14:15:42 +0000 (16:15 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 10 Nov 2022 16:57:49 +0000 (17:57 +0100)
commit88e2ddde542205d3b01ad2547186554e8e7c46ec
tree45e90548789c05bcee8191959527e9592975d6f3
parenta21ddf5fe103f08f614e447feea99ab0ecb5f65f
RDMA/cma: Use output interface for net_dev check

[ Upstream commit 439d79b8cf277495a77bb048cb2c280d535f4f1f ]

Commit a0fc9e6c5943 ("RDMA/cma: Fix arguments order in net device
validation") swapped the src and dst addresses in the call to
validate_net_dev().

As a consequence, the test in validate_ipv4_net_dev() to see if the
net_dev is the right one, is incorrect for port 1 <-> 2 communication when
the ports are on the same sub-net. This is fixed by denoting the
flowi4_oif as the device instead of the incoming one.

The bug has not been observed using IPv6 addresses.

Fixes: a0fc9e6c5943 ("RDMA/cma: Fix arguments order in net device validation")
Signed-off-by: Håkon Bugge <haakon.bugge@oracle.com>
Link: https://lore.kernel.org/r/20221012141542.16925-1-haakon.bugge@oracle.com
Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
Signed-off-by: Leon Romanovsky <leon@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/infiniband/core/cma.c