]> git.baikalelectronics.ru Git - kernel.git/commit
Revert "mm: compaction: handle incorrect MIGRATE_UNMOVABLE type pageblocks"
authorLinus Torvalds <torvalds@linux-foundation.org>
Mon, 4 Jun 2012 03:05:57 +0000 (20:05 -0700)
committerLinus Torvalds <torvalds@linux-foundation.org>
Mon, 4 Jun 2012 03:05:57 +0000 (20:05 -0700)
commit88c04101310e61c92e18f2bedafbb3e32ee6e6f4
tree0a825d6f78e43d9ecc86429a99dcb40ed6628c25
parenta9d95be3656b8d7fffe816c440167487883db122
Revert "mm: compaction: handle incorrect MIGRATE_UNMOVABLE type pageblocks"

This reverts commit a6ebb32702cf26cce0372b596cb26f4bbe3959df.

That commit seems to be the cause of the mm compation list corruption
issues that Dave Jones reported.  The locking (or rather, absense
there-of) is dubious, as is the use of the 'page' variable once it has
been found to be outside the pageblock range.

So revert it for now, we can re-visit this for 3.6.  If we even need to:
as Minchan Kim says, "The patch wasn't a bug fix and even test workload
was very theoretical".

Reported-and-tested-by: Dave Jones <davej@redhat.com>
Acked-by: Hugh Dickins <hughd@google.com>
Acked-by: KOSAKI Motohiro <kosaki.motohiro@gmail.com>
Acked-by: Minchan Kim <minchan@kernel.org>
Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Cc: Kyungmin Park <kyungmin.park@samsung.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
include/linux/compaction.h
mm/compaction.c
mm/internal.h
mm/page_alloc.c