]> git.baikalelectronics.ru Git - kernel.git/commit
binderfs: prevent renaming the control dentry
authorChristian Brauner <christian@brauner.io>
Mon, 21 Jan 2019 10:48:03 +0000 (11:48 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 22 Jan 2019 11:25:53 +0000 (12:25 +0100)
commit88aab75aee3ac2c80029038b694114e332a16bd9
treebf5bd8f3cd65048a8f44455b52d7697bc4b29016
parent9d788752298d259eca7fff49cf30828c744b4d5f
binderfs: prevent renaming the control dentry

- make binderfs control dentry immutable:
  We don't allow to unlink it since it is crucial for binderfs to be
  useable but if we allow to rename it we make the unlink trivial to
  bypass. So prevent renaming too and simply treat the control dentry as
  immutable.

- add is_binderfs_control_device() helper:
  Take the opportunity and turn the check for the control dentry into a
  separate helper is_binderfs_control_device() since it's now used in two
  places.

- simplify binderfs_rename():
  Instead of hand-rolling our custom version of simple_rename() just dumb
  the whole function down to first check whether we're trying to rename the
  control dentry. If we do EPERM the caller and if not call simple_rename().

Suggested-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Christian Brauner <christian@brauner.io>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/android/binderfs.c