]> git.baikalelectronics.ru Git - kernel.git/commit
ethtool: fix reference leak in some *_SET handlers
authorMichal Kubecek <mkubecek@suse.cz>
Sun, 22 Mar 2020 21:24:21 +0000 (22:24 +0100)
committerDavid S. Miller <davem@davemloft.net>
Tue, 24 Mar 2020 04:50:14 +0000 (21:50 -0700)
commit88a73c19c2742f254a3dcdeb77e093b0c644013f
tree100399068cdeafc3d9e050e2f52a95b0938813aa
parentc35f5d0592e8fcdbf1333a249129ac80bdd66604
ethtool: fix reference leak in some *_SET handlers

Andrew noticed that some handlers for *_SET commands leak a netdev
reference if required ethtool_ops callbacks do not exist. A simple
reproducer would be e.g.

  ip link add veth1 type veth peer name veth2
  ethtool -s veth1 wol g
  ip link del veth1

Make sure dev_put() is called when ethtool_ops check fails.

v2: add Fixes tags

Fixes: c7aaebe4a201 ("ethtool: set link settings with LINKINFO_SET request")
Fixes: 3ae84021872e ("ethtool: set link modes related data with LINKMODES_SET request")
Fixes: e80df2d13ab6 ("ethtool: set message mask with DEBUG_SET request")
Fixes: 0c623c13cee9 ("ethtool: set wake-on-lan settings with WOL_SET request")
Reported-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: Michal Kubecek <mkubecek@suse.cz>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Reviewed-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ethtool/debug.c
net/ethtool/linkinfo.c
net/ethtool/linkmodes.c
net/ethtool/wol.c