]> git.baikalelectronics.ru Git - kernel.git/commit
Revert "ACPI: processor: idle: Only flush cache on entering C3"
authorAkihiko Odaki <akihiko.odaki@gmail.com>
Sun, 3 Apr 2022 06:23:22 +0000 (15:23 +0900)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Mon, 4 Apr 2022 18:51:15 +0000 (20:51 +0200)
commit88665775d0c3ba9e451b1b3f0e2f22fd7302cfe1
treed8d48c89b5ad08cbb73171de1d36477eda4841f2
parentdbb008736a8c113ef1e12b4e4b4351fac2a15ede
Revert "ACPI: processor: idle: Only flush cache on entering C3"

Revert commit 46847eea9e33 ("ACPI: processor: idle: Only flush cache
on entering C3") that broke the assumptions of the acpi_idle_play_dead()
callers.

Namely, the CPU cache must always be flushed in acpi_idle_play_dead(),
regardless of the target C-state that is going to be requested, because
this is likely to be part of a CPU offline procedure or preparation for
entering a system-wide sleep state and the lack of synchronization
between the CPU cache and RAM may lead to problems going forward, for
example when the CPU is brought back online.

In particular, it breaks resume from suspend-to-RAM on Lenovo ThinkPad
C13 which fails occasionally until the problematic commit is reverted.

Signed-off-by: Akihiko Odaki <akihiko.odaki@gmail.com>
[ rjw: Changelog ]
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
drivers/acpi/processor_idle.c