]> git.baikalelectronics.ru Git - kernel.git/commit
time: Make settimeofday error checking work again
authorJohn Stultz <john.stultz@linaro.org>
Wed, 1 Jun 2016 18:53:26 +0000 (11:53 -0700)
committerThomas Gleixner <tglx@linutronix.de>
Wed, 1 Jun 2016 19:13:43 +0000 (21:13 +0200)
commit87329bc80e422dcdf653d6463da15fc3117b77b4
tree2dc402ef2db9972b048b1dbe80d6b5122cd6eb7a
parent50071cc55229e13f7b459c28388ff0f4e1bac824
time: Make settimeofday error checking work again

In commit d261a2f07fff some of the checking for a valid timeval
was subtley changed which caused -EINVAL to be returned whenever
the timeval was null.

However, it is possible to set the timezone data while specifying
a NULL timeval, which is usually done to handle systems where the
RTC keeps local time instead of UTC. Thus the patch causes such
systems to have the time incorrectly set.

This patch addresses the issue by handling the error conditionals
in the same way as was done previously.

Fixes: d261a2f07fff "time: Introduce do_sys_settimeofday64()"
Reported-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Signed-off-by: John Stultz <john.stultz@linaro.org>
Tested-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Cc: Prarit Bhargava <prarit@redhat.com>
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Baolin Wang <baolin.wang@linaro.org>
Cc: Richard Cochran <richardcochran@gmail.com>
Cc: Shuah Khan <shuahkh@osg.samsung.com>
Link: http://lkml.kernel.org/r/1464807207-16530-2-git-send-email-john.stultz@linaro.org
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
include/linux/timekeeping.h