]> git.baikalelectronics.ru Git - kernel.git/commit
projects / kernel.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: f717ecb) | patch
devlink: double free in devlink_resource_fill()
authorDan Carpenter <dan.carpenter@oracle.com>
Fri, 21 Sep 2018 08:07:55 +0000 (11:07 +0300)
committerDavid S. Miller <davem@davemloft.net>
Sat, 22 Sep 2018 02:19:07 +0000 (19:19 -0700)
commit86f038ebdbb86b37311330e125a774b4c7d66fc5
tree11945dfd4538b07a1cd32e8093b20b8bbbb1b988tree | snapshot
parentf717ecb1ca6619151c6faba2eb2bb67cd26761b5commit | diff
devlink: double free in devlink_resource_fill()

Smatch reports that devlink_dpipe_send_and_alloc_skb() frees the skb
on error so this is a double free.  We fixed a bunch of these bugs in
commit 2351d4ed22b6 ("devlink: Remove redundant free on error path") but
we accidentally overlooked this one.

Fixes: a17ea8acaaac ("devlink: Add support for resource abstraction")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/core/devlink.c diff | blob | history
Linux Kernel Source Tree.