]> git.baikalelectronics.ru Git - kernel.git/commit
net/rds: Fix a use after free in rds_message_map_pages
authorLv Yunlong <lyl2019@mail.ustc.edu.cn>
Wed, 31 Mar 2021 01:59:59 +0000 (18:59 -0700)
committerDavid S. Miller <davem@davemloft.net>
Wed, 31 Mar 2021 21:26:56 +0000 (14:26 -0700)
commit86a79b79a2521fd789dd80b9b8d183711ddfa824
treee4de98593b2567237161731b200b533b4de41f87
parent1373da1ae843fdbaad5522c1a58a44e0960b0b10
net/rds: Fix a use after free in rds_message_map_pages

In rds_message_map_pages, the rm is freed by rds_message_put(rm).
But rm is still used by rm->data.op_sg in return value.

My patch assigns ERR_CAST(rm->data.op_sg) to err before the rm is
freed to avoid the uaf.

Fixes: e0838d5351e00 ("net/rds: Use ERR_PTR for rds_message_alloc_sgs()")
Signed-off-by: Lv Yunlong <lyl2019@mail.ustc.edu.cn>
Reviewed-by: HÃ¥kon Bugge <haakon.bugge@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/rds/message.c