]> git.baikalelectronics.ru Git - kernel.git/commit
s390/cio: remove uevent suppress from cio driver
authorVineeth Vijayan <vneethv@linux.ibm.com>
Tue, 29 Jun 2021 07:38:22 +0000 (09:38 +0200)
committerHeiko Carstens <hca@linux.ibm.com>
Mon, 6 Dec 2021 13:42:24 +0000 (14:42 +0100)
commit86599b8ad68baed6f1d2b991a66dab1d8530a0c8
tree0daff9dacc91786c9c17442677fdb02872b35657
parent951a703c63a4ea7d2517a60107cc5395e578a376
s390/cio: remove uevent suppress from cio driver

commit d77319941523 ("s390: cio: Delay uevents for subchannels")
introduced suppression of uevents for a subchannel until after it is
clear that the subchannel would not be unregistered again
immediately. This was done to avoid uevents being generated for I/O
subchannels with no valid device, which can happen on LPAR.

However, this also has some drawbacks: All subchannel drivers need to
manually remove the uevent suppression and generate an ADD uevent as
soon as they are sure that the subchannel will stay around. This misses
out on all uevents that are not the initial ADD uevent that would be
generated while uevents are suppressed; for example, all subchannels
were missing the BIND uevent.

As uevents being generated even for I/O subchannels without an
operational device turned out to be not as bad as missing uevents and
complicating the code flow, let's remove uevent suppression for
subchannels.

Signed-off-by: Vineeth Vijayan <vneethv@linux.ibm.com>
[cohuck@redhat.com: modified changelog]
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
Reviewed-by: Peter Oberparleiter <oberpar@linux.ibm.com>
Link: https://lore.kernel.org/r/20211122103756.352463-2-vneethv@linux.ibm.com
Signed-off-by: Heiko Carstens <hca@linux.ibm.com>
drivers/s390/cio/chsc_sch.c
drivers/s390/cio/css.c
drivers/s390/cio/device.c
drivers/s390/cio/eadm_sch.c
drivers/s390/cio/vfio_ccw_drv.c