]> git.baikalelectronics.ru Git - kernel.git/commit
perf options: Check v type in OPT_U?INTEGER
authorArnaldo Carvalho de Melo <acme@redhat.com>
Mon, 17 May 2010 18:39:16 +0000 (15:39 -0300)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Mon, 17 May 2010 18:43:38 +0000 (15:43 -0300)
commit86534cb83933cde060914135432b4bd269c54b3f
treee9788fe79c7d2af4ad1fab0d9cfe4b3822f468ff
parentb9158baccab7fc05aa9bd709ffcc078bc698486a
perf options: Check v type in OPT_U?INTEGER

To avoid problems like the one fixed by Stephane Eranian in 12de478, now
we'll got this instead:

bench/sched-messaging.c:259: error: negative width in bit-field ‘<anonymous>’
bench/sched-messaging.c:261: error: negative width in bit-field ‘<anonymous>’

Which is rather cryptic, but is how BUILD_BUG_ON_ZERO works, so kernel
hackers should be already used to this.

With it in place found some problems, fixed by changing the affected
variables to sensible types or changed some OPT_INTEGER to OPT_UINTEGER.

Next csets will go thru converting each of the remaining OPT_ so that
review can be made easier by grouping changes per type per patch.

Cc: Frédéric Weisbecker <fweisbec@gmail.com>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Stephane Eranian <eranian@google.com>
Cc: Tom Zanussi <tzanussi@gmail.com>
LKML-Reference: <new-submission>
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/bench/sched-messaging.c
tools/perf/builtin-record.c
tools/perf/builtin-sched.c
tools/perf/builtin-top.c
tools/perf/util/include/linux/kernel.h
tools/perf/util/parse-options.h