]> git.baikalelectronics.ru Git - kernel.git/commit
once: add DO_ONCE_SLOW() for sleepable contexts
authorEric Dumazet <edumazet@google.com>
Sat, 1 Oct 2022 20:51:02 +0000 (13:51 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 26 Oct 2022 11:22:27 +0000 (13:22 +0200)
commit85d3a3d8da28aa0ca182c7d4993add835a412821
tree1a9158e4e2d95bace7a161c3fd85b24b596d9a7b
parenta5b7b3edf66ad105e14b269f61b551cd97c01bab
once: add DO_ONCE_SLOW() for sleepable contexts

[ Upstream commit 4021e1a2ce29270d2f9e54b439d5ab578f7d175e ]

Christophe Leroy reported a ~80ms latency spike
happening at first TCP connect() time.

This is because __inet_hash_connect() uses get_random_once()
to populate a perturbation table which became quite big
after commit 85bf0dc6b58d ("tcp: increase source port perturb table to 2^16")

get_random_once() uses DO_ONCE(), which block hard irqs for the duration
of the operation.

This patch adds DO_ONCE_SLOW() which uses a mutex instead of a spinlock
for operations where we prefer to stay in process context.

Then __inet_hash_connect() can use get_random_slow_once()
to populate its perturbation table.

Fixes: 85bf0dc6b58d ("tcp: increase source port perturb table to 2^16")
Fixes: 57c2c1517858 ("tcp: change source port randomizarion at connect() time")
Reported-by: Christophe Leroy <christophe.leroy@csgroup.eu>
Link: https://lore.kernel.org/netdev/CANn89iLAEYBaoYajy0Y9UmGFff5GPxDUoG-ErVB2jDdRNQ5Tug@mail.gmail.com/T/#t
Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: Willy Tarreau <w@1wt.eu>
Tested-by: Christophe Leroy <christophe.leroy@csgroup.eu>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
include/linux/once.h
lib/once.c
net/ipv4/inet_hashtables.c