]> git.baikalelectronics.ru Git - kernel.git/commit
kconfig: fix broken dependency in randconfig-generated .config
authorMasahiro Yamada <masahiroy@kernel.org>
Sat, 1 Feb 2020 05:03:11 +0000 (14:03 +0900)
committerMasahiro Yamada <masahiroy@kernel.org>
Mon, 3 Feb 2020 16:49:12 +0000 (01:49 +0900)
commit85560807c0022cdddebd9661a3998b5ac5fa671b
tree7b8141c3925ebbd971f0ecd16cdb8778cd64cd00
parent2884cf9b7bed9e51821b262531cdcb9e76175cf9
kconfig: fix broken dependency in randconfig-generated .config

Running randconfig on arm64 using KCONFIG_SEED=0x40C5E904 (e.g. on v5.5)
produces the .config with CONFIG_EFI=y and CONFIG_CPU_BIG_ENDIAN=y,
which does not meet the !CONFIG_CPU_BIG_ENDIAN dependency.

This is because the user choice for CONFIG_CPU_LITTLE_ENDIAN vs
CONFIG_CPU_BIG_ENDIAN is set by randomize_choice_values() after the
value of CONFIG_EFI is calculated.

When this happens, the has_changed flag should be set.

Currently, it takes the result from the last iteration. It should
accumulate all the results of the loop.

Fixes: 0cb2a8d9ae6d ("kconfig: loop as long as we changed some symbols in randconfig")
Reported-by: Vincenzo Frascino <vincenzo.frascino@arm.com>
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
scripts/kconfig/confdata.c