]> git.baikalelectronics.ru Git - kernel.git/commit
Revert "thermal: rockchip: fix up the tsadc pinctrl setting error"
authorHeiko Stuebner <heiko@sntech.de>
Wed, 22 May 2019 14:12:36 +0000 (16:12 +0200)
committerEduardo Valentin <edubezval@gmail.com>
Fri, 24 May 2019 04:48:58 +0000 (21:48 -0700)
commit8542a5794b284a833c3b19c6d7bdffb03e1eb623
tree21145fb4d1312fe0f2b9c9d414acb3f268c562fa
parent16fcceeab28ea4e9a10b1750cff14dfeb287142e
Revert "thermal: rockchip: fix up the tsadc pinctrl setting error"

This reverts commit 8ecce283e6181c55dc84b201404d5bbdde610497.

The commit causes multiple issues in that:
- the added call to ->control does potentially run unclocked
  causing a hang of the machine
- the added pinctrl-states are undocumented in the binding
- the added pinctrl-states are not backwards compatible, breaking
  old devicetrees.

Fixes: 8ecce283e618 ("thermal: rockchip: fix up the tsadc pinctrl setting error")
Signed-off-by: Heiko Stuebner <heiko@sntech.de>
Reported-by: kernelci.org bot <bot@kernelci.org>
Reported-by: Enric Balletbo Serra <eballetbo@gmail.com>
Reported-by: Vicente Bergas <vicencb@gmail.com>
Reported-by: Jack Mitchell <ml@embed.me.uk>
Reported-by: Douglas Anderson <dianders@chromium.org>
Tested-by: Douglas Anderson <dianders@chromium.org>
Signed-off-by: Eduardo Valentin <edubezval@gmail.com>
drivers/thermal/rockchip_thermal.c