]> git.baikalelectronics.ru Git - kernel.git/commit
xfs: use bitops interface for buf log item AIL flag check
authorBrian Foster <bfoster@redhat.com>
Sat, 24 Sep 2022 12:56:51 +0000 (18:26 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 28 Sep 2022 09:04:11 +0000 (11:04 +0200)
commit85167a8faff08d180b3d2aa3447d02805a9f3135
treeb1ba7a7fa3d3cd3138d0d8364f7d38b06d01f656
parent3deb143c4cb4ec02f202ca1279613354f5ea6ea7
xfs: use bitops interface for buf log item AIL flag check

commit 419552467bcc5dfd0c5d0f740af3877019597946 upstream.

The xfs_log_item flags were converted to atomic bitops as of commit
193c535844 ("xfs: log item flags are racy"). The assert check for
AIL presence in xfs_buf_item_relse() still uses the old value based
check. This likely went unnoticed as XFS_LI_IN_AIL evaluates to 0
and causes the assert to unconditionally pass. Fix up the check.

Signed-off-by: Brian Foster <bfoster@redhat.com>
Fixes: 193c535844 ("xfs: log item flags are racy")
Reviewed-by: Eric Sandeen <sandeen@redhat.com>
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Acked-by: Darrick J. Wong <djwong@kernel.org>
Signed-off-by: Chandan Babu R <chandan.babu@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
fs/xfs/xfs_buf_item.c