]> git.baikalelectronics.ru Git - kernel.git/commit
bluetooth: btusb: Replace GFP_ATOMIC with GFP_KERNEL in inject_cmd_complete()
authorJia-Ju Bai <baijiaju1990@gmail.com>
Mon, 23 Jul 2018 03:38:51 +0000 (11:38 +0800)
committerMarcel Holtmann <marcel@holtmann.org>
Mon, 23 Jul 2018 16:05:00 +0000 (18:05 +0200)
commit850c4c773daa8acfd0a7aa20da4e71613d5076bf
treefc86899c2dfbe213ac9c131833dd996a12c33983
parent5a54543feb41eaf2e80a19df2d859332b5cd2ba2
bluetooth: btusb: Replace GFP_ATOMIC with GFP_KERNEL in inject_cmd_complete()

inject_cmd_complete() is only called by btusb_send_frame_intel(),
which is set to hdev->send, and hdev->send() is never
called in atomic context.

inject_cmd_complete() calls bt_skb_alloc() with GFP_ATOMIC,
which is not necessary.
GFP_ATOMIC can be replaced with GFP_KERNEL.

This is found by a static analysis tool named DCNS written by myself.
I also manually check the kernel code before reporting it.

Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
drivers/bluetooth/btusb.c