]> git.baikalelectronics.ru Git - kernel.git/commit
nilfs2: fix incorrect masking of permission flags for symlinks
authorRyusuke Konishi <konishi.ryusuke@gmail.com>
Thu, 23 Jun 2022 08:54:01 +0000 (17:54 +0900)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 21 Jul 2022 19:24:14 +0000 (21:24 +0200)
commit844df78a18e8f2a502e2912da8d6331c05dbee02
treea620ce8379ac45c6c0417cbf1dfb077a9d5ae603
parent7485024246c0fc650d6f6da3ffd679d5361b38d5
nilfs2: fix incorrect masking of permission flags for symlinks

commit ee8d7e9ebef5c9bc5720b7f0fb54ff403bb34b38 upstream.

The permission flags of newly created symlinks are wrongly dropped on
nilfs2 with the current umask value even though symlinks should have 777
(rwxrwxrwx) permissions:

 $ umask
 0022
 $ touch file && ln -s file symlink; ls -l file symlink
 -rw-r--r--. 1 root root 0 Jun 23 16:29 file
 lrwxr-xr-x. 1 root root 4 Jun 23 16:29 symlink -> file

This fixes the bug by inserting a missing check that excludes
symlinks.

Link: https://lkml.kernel.org/r/1655974441-5612-1-git-send-email-konishi.ryusuke@gmail.com
Signed-off-by: Ryusuke Konishi <konishi.ryusuke@gmail.com>
Reported-by: Tommy Pettersson <ptp@lysator.liu.se>
Reported-by: Ciprian Craciun <ciprian.craciun@gmail.com>
Tested-by: Ryusuke Konishi <konishi.ryusuke@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
fs/nilfs2/nilfs.h