]> git.baikalelectronics.ru Git - kernel.git/commit
wifi: plfxlc: remove redundant NULL-check for GCC 12
authorJakub Kicinski <kuba@kernel.org>
Fri, 20 May 2022 19:43:13 +0000 (12:43 -0700)
committerJakub Kicinski <kuba@kernel.org>
Mon, 23 May 2022 00:23:05 +0000 (17:23 -0700)
commit844c9d6c0d19a790152d4e5e72d83fcbbbed42c8
tree4dc6c249bf4759b27ad1b7f96acfdcc544a67bb3
parent5acd16392972b68f9b20ad160021dff4746c7090
wifi: plfxlc: remove redundant NULL-check for GCC 12

GCC is upset that we check the return value of plfxlc_usb_dev()
even tho it can't be NULL:

drivers/net/wireless/purelifi/plfxlc/usb.c: In function ‘resume’:
drivers/net/wireless/purelifi/plfxlc/usb.c:840:20: warning: the comparison will always evaluate as ‘true’ for the address of ‘dev’ will never be NULL [-Waddress]
  840 |         if (!pl || !plfxlc_usb_dev(pl))
      |                    ^

plfxlc_usb_dev() returns an address of one of the members of pl,
so it's safe to drop these checks.

Acked-by: Kalle Valo <kvalo@kernel.org>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/wireless/purelifi/plfxlc/usb.c