]> git.baikalelectronics.ru Git - kernel.git/commit
usb: xhci-mtk: fix bandwidth release issue
authorChunfeng Yun <chunfeng.yun@mediatek.com>
Fri, 19 Aug 2022 08:05:56 +0000 (16:05 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 19 Aug 2022 08:39:08 +0000 (10:39 +0200)
commit8423b3c5ae3d8d99e9cf8fc9eeea9141a226e2fd
tree382bc8314f057c55f7aeb7f75260fbed699cc4b3
parent20b126b1677cef546601e40422f3b145b253ff36
usb: xhci-mtk: fix bandwidth release issue

This happens when @udev->reset_resume is set to true, when usb resume,
the flow as below:
  - hub_resume
    - usb_disable_interface
      - usb_disable_endpoint
        - usb_hcd_disable_endpoint
          - xhci_endpoint_disable  // it set @ep->hcpriv to NULL

Then when reset usb device, it will drop allocated endpoints,
the flow as below:
  - usb_reset_and_verify_device
    - usb_hcd_alloc_bandwidth
      - xhci_mtk_drop_ep

but @ep->hcpriv is already set to NULL, the bandwidth will be not
released anymore.

Due to the added endponts are stored in hash table, we can drop the check
of @ep->hcpriv.

Fixes: 349f622cd0d4 ("usb: xhci-mtk: Do not use xhci's virt_dev in drop_endpoint")
Cc: stable <stable@kernel.org>
Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
Link: https://lore.kernel.org/r/20220819080556.32215-2-chunfeng.yun@mediatek.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/host/xhci-mtk-sch.c