]> git.baikalelectronics.ru Git - kernel.git/commit
ALSA: echoaudio: Fix the missing snd_card_free() call at probe error
authorTakashi Iwai <tiwai@suse.de>
Tue, 12 Apr 2022 09:31:41 +0000 (11:31 +0200)
committerTakashi Iwai <tiwai@suse.de>
Tue, 12 Apr 2022 09:48:09 +0000 (11:48 +0200)
commit8400002a6e9a98131af3d126f5f189cb5fbdf57b
treeb4b534b693c8ef7e6803d9d7e1b981eb7a0a1e9b
parentc6116cc30475eebfe91fdefac28fda78f9febea3
ALSA: echoaudio: Fix the missing snd_card_free() call at probe error

The previous cleanup with devres may lead to the incorrect release
orders at the probe error handling due to the devres's nature.  Until
we register the card, snd_card_free() has to be called at first for
releasing the stuff properly when the driver tries to manage and
release the stuff via card->private_free().

This patch fixes it by calling snd_card_free() on the error from the
probe callback using a new helper function.

Fixes: 3dabff5c2ae7 ("ALSA: echoaudio: Allocate resources with device-managed APIs")
Reported-and-tested-by: Zheyu Ma <zheyuma97@gmail.com>
Cc: <stable@vger.kernel.org>
Link: https://lore.kernel.org/r/CAMhUBjm2AdyEZ_-EgexdNDN7SvY4f89=4=FwAL+c0Mg0O+X50A@mail.gmail.com
Link: https://lore.kernel.org/r/20220412093141.8008-3-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/pci/echoaudio/echoaudio.c