]> git.baikalelectronics.ru Git - kernel.git/commit
usb: chipidea: fix missing goto in `ci_hdrc_probe`
authorYinhao Hu <dddddd@hust.edu.cn>
Wed, 12 Apr 2023 05:58:52 +0000 (13:58 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 17 May 2023 09:35:49 +0000 (11:35 +0200)
commit83f88d61892dc08165dbccf67413c254e526aa57
tree8b78dc9ecf841e1fbf060f40e088a39fe7f8c196
parent7d3f3d790c6ba01749f2953744559b504023a8e6
usb: chipidea: fix missing goto in `ci_hdrc_probe`

[ Upstream commit d6f712f53b79f5017cdcefafb7a5aea9ec52da5d ]

From the comment of ci_usb_phy_init, it returns an error code if
usb_phy_init has failed, and it should do some clean up, not just
return directly.

Fix this by goto the error handling.

Fixes: 726d284f87b5 ("usb: chipidea: move PHY operation to core")
Reviewed-by: Dongliang Mu <dzm91@hust.edu.cn>
Acked-by: Peter Chen <peter.chen@kernel.org>
Signed-off-by: Yinhao Hu <dddddd@hust.edu.cn>
Link: https://lore.kernel.org/r/20230412055852.971991-1-dddddd@hust.edu.cn
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/usb/chipidea/core.c