]> git.baikalelectronics.ru Git - kernel.git/commit
drm/i915/selftests: Force bonded submission to overlap
authorChris Wilson <chris@chris-wilson.co.uk>
Fri, 22 Nov 2019 11:21:48 +0000 (11:21 +0000)
committerChris Wilson <chris@chris-wilson.co.uk>
Fri, 22 Nov 2019 13:06:36 +0000 (13:06 +0000)
commit83f1149bd8b259cc9b21348087679da37287347f
treee32f6755f809f57b61f74f5a9404e1ffe652430c
parent5fa4558c467dc256cfe1d1aa7704a618b5df0e26
drm/i915/selftests: Force bonded submission to overlap

Bonded request submission is designed to allow requests to execute in
parallel as laid out by the user. If the master request is already
finished before its bonded pair is submitted, the pair were not destined
to run in parallel and we lose the information about the master engine
to dictate selection of the secondary. If the second request was
required to be run on a particular engine in a virtual set, that should
have been specified, rather than left to the whims of a random
unconnected requests!

In the selftest, I made the mistake of not ensuring the master would
overlap with its bonded pairs, meaning that it could indeed complete
before we submitted the bonds. Those bonds were then free to select any
available engine in their virtual set, and not the one expected by the
test.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20191122112152.660743-1-chris@chris-wilson.co.uk
drivers/gpu/drm/i915/gt/selftest_lrc.c