]> git.baikalelectronics.ru Git - kernel.git/commit
jbd2: Drop pointless check from jbd2_journal_stop()
authorJan Kara <jack@suse.cz>
Tue, 5 Nov 2019 16:44:21 +0000 (17:44 +0100)
committerTheodore Ts'o <tytso@mit.edu>
Tue, 5 Nov 2019 21:00:48 +0000 (16:00 -0500)
commit83c93a3f7edfe815ffbd38778a9dceab8a4a5419
tree556dbb10760d06168e671883201a12c481c67a32
parent22127b0d711cf54314c26f12bd1826a8b6db1185
jbd2: Drop pointless check from jbd2_journal_stop()

If a transaction is larger than journal->j_max_transaction_buffers, that
is a bug and not a trigger for transaction commit. Also the very next
attempt to start new handle will start transaction commit anyway. So
just remove the pointless check. Arguably, we could start transaction
commit whenever the transaction size is *close* to
journal->j_max_transaction_buffers. This has a potential to reduce
latency of the next jbd2_journal_start() at the cost of somewhat smaller
transactions. However for this to have any effect, it would mean that
there isn't someone already waiting in jbd2_journal_start() which means
metadata load for the fs is pretty light anyway so probably this
optimization is not worth it.

Reviewed-by: Theodore Ts'o <tytso@mit.edu>
Signed-off-by: Jan Kara <jack@suse.cz>
Link: https://lore.kernel.org/r/20191105164437.32602-15-jack@suse.cz
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
fs/jbd2/transaction.c