]> git.baikalelectronics.ru Git - kernel.git/commit
net: moxa: fix UAF in moxart_mac_probe
authorPavel Skripkin <paskripkin@gmail.com>
Fri, 9 Jul 2021 14:09:53 +0000 (17:09 +0300)
committerDavid S. Miller <davem@davemloft.net>
Fri, 9 Jul 2021 18:01:01 +0000 (11:01 -0700)
commit8283b643492ecf4a863981c44285aa0d99fd3dd8
tree417e6a280a7c901151ca223b6c1d224e3277acac
parentf8c46d2495415d5df32abb97c063261ca7d87377
net: moxa: fix UAF in moxart_mac_probe

In case of netdev registration failure the code path will
jump to init_fail label:

init_fail:
netdev_err(ndev, "init failed\n");
moxart_mac_free_memory(ndev);
irq_map_fail:
free_netdev(ndev);
return ret;

So, there is no need to call free_netdev() before jumping
to error handling path, since it can cause UAF or double-free
bug.

Fixes: db202486f4cf ("net: Add MOXA ART SoCs ethernet driver")
Signed-off-by: Pavel Skripkin <paskripkin@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/moxa/moxart_ether.c