]> git.baikalelectronics.ru Git - kernel.git/commit
platform/x86: dell-wmi-sysman: Cleanup create_attributes_level_sysfs_files()
authorHans de Goede <hdegoede@redhat.com>
Sun, 21 Mar 2021 11:59:01 +0000 (12:59 +0100)
committerHans de Goede <hdegoede@redhat.com>
Sun, 21 Mar 2021 16:47:36 +0000 (17:47 +0100)
commit82455e1fdaa4c7c8d1961abdf9e4823af93276df
tree8323046c1c35206746b0997b512c7d796405e849
parentccecdd5576f60b54d720f9d9fdc1d41a48dbbbef
platform/x86: dell-wmi-sysman: Cleanup create_attributes_level_sysfs_files()

Cleanup create_attributes_level_sysfs_files():

1. There is no need to call sysfs_remove_file() on error, sysman_init()
will already call release_attributes_data() on failure which already does
this.

2. There is no need for the pr_debug() calls sysfs_create_file() should
never fail and if it does it will already complain about the problem
itself.

Fixes: 25afa9d472ce ("platform/x86: Introduce support for Systems Management Driver over WMI for Dell Systems")
Cc: Divya Bharathi <Divya_Bharathi@dell.com>
Cc: Mario Limonciello <mario.limonciello@dell.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Link: https://lore.kernel.org/r/20210321115901.35072-8-hdegoede@redhat.com
drivers/platform/x86/dell/dell-wmi-sysman/sysman.c