]> git.baikalelectronics.ru Git - kernel.git/commit
mtd: rawnand: meson: Fix a potential double free issue
authorChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Fri, 20 May 2022 16:41:40 +0000 (18:41 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 25 Aug 2022 09:17:50 +0000 (11:17 +0200)
commit8220c538a0d10bf8e754b30da8c54eb4462f624b
tree6ae1259956352257f0aa0ded7d36b8f0a368e758
parent73d37da4f68ddc667ae0866bbd4234b7465ceed7
mtd: rawnand: meson: Fix a potential double free issue

[ Upstream commit c5f9a0e5bd41936e90d80485d3fb1aa00bc1f16f ]

When meson_nfc_nand_chip_cleanup() is called, it will call:
meson_nfc_free_buffer(&meson_chip->nand);
nand_cleanup(&meson_chip->nand);

nand_cleanup() in turn will call nand_detach() which calls the
.detach_chip() which is here meson_nand_detach_chip().

meson_nand_detach_chip() already calls meson_nfc_free_buffer(), so we
could double free some memory.

Fix it by removing the unneeded explicit call to meson_nfc_free_buffer().

Fixes: 9080445870ff ("mtd: rawnand: meson: add support for Amlogic NAND flash controller")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Acked-by: Liang Yang <liang.yang@amlogic.com>
Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
Link: https://lore.kernel.org/linux-mtd/ec15c358b8063f7c50ff4cd628cf0d2e14e43f49.1653064877.git.christophe.jaillet@wanadoo.fr
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/mtd/nand/raw/meson_nand.c