]> git.baikalelectronics.ru Git - kernel.git/commit
HID: vivaldi: fix sysfs attributes leak
authorDmitry Torokhov <dmitry.torokhov@gmail.com>
Sat, 26 Feb 2022 01:18:58 +0000 (17:18 -0800)
committerJiri Kosina <jkosina@suse.cz>
Tue, 1 Mar 2022 14:31:17 +0000 (15:31 +0100)
commit81d3c414767781686a408a12f12766ae71ccd3d6
tree3947d96fc7680fdd5df7ce11c474ee59bcd9db39
parent58c57c758dd39a8908c46768d8bb9936d428acc5
HID: vivaldi: fix sysfs attributes leak

The driver creates the top row map sysfs attribute in input_configured()
method; unfortunately we do not have a callback that is executed when HID
interface is unbound, thus we are leaking these sysfs attributes, for
example when device is disconnected.

To fix it let's switch to managed version of adding sysfs attributes which
will ensure that they are destroyed when the driver is unbound.

Fixes: 7053d006b6d3 ("HID: add vivaldi HID driver")
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Tested-by: Stephen Boyd <swboyd@chromium.org>
Reviewed-by: Stephen Boyd <swboyd@chromium.org>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
drivers/hid/hid-vivaldi.c