]> git.baikalelectronics.ru Git - kernel.git/commit
staging: rtl8723bs: Fix incorrect sense of ether_addr_equal
authorLarry Finger <Larry.Finger@lwfinger.net>
Wed, 7 Nov 2018 03:33:14 +0000 (21:33 -0600)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 7 Nov 2018 12:08:28 +0000 (13:08 +0100)
commit8194b3ed1c8229b7ac5c0b043210813592301c11
tree0bb73dfcb5f11afa9a43b61fe69e25fca410acdc
parentb0c78e48b35da640c67e9a37e6d7f7c8019f90dd
staging: rtl8723bs: Fix incorrect sense of ether_addr_equal

In commit da3c28e0d663 ("staging: rtl8723bs: Fix lines too long in
update_recvframe_attrib()."), the refactoring involved replacing
two memcmp() calls with ether_addr_equal() calls. What the author
missed is that memcmp() returns false when the two strings are equal,
whereas ether_addr_equal() returns true when the two addresses are
equal. One side effect of this error is that the strength of an
unassociated AP was much stronger than the same AP after association.
This bug is reported at bko#201611.

Fixes: da3c28e0d663 ("staging: rtl8723bs: Fix lines too long in update_recvframe_attrib().")
Cc: Stable <stable@vger.kernel.org>
Cc: youling257 <youling257@gmail.com>
Cc: u.srikant.patnaik@gmail.com
Reported-and-tested-by: youling257 <youling257@gmail.com>
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/rtl8723bs/hal/rtl8723bs_recv.c