]> git.baikalelectronics.ru Git - kernel.git/commit
crypto: vmx - ghash: do nosimd fallback manually
authorDaniel Axtens <dja@axtens.net>
Thu, 16 May 2019 15:40:02 +0000 (01:40 +1000)
committerHerbert Xu <herbert@gondor.apana.org.au>
Fri, 17 May 2019 05:36:54 +0000 (13:36 +0800)
commit816a63e925f0a539e2960d8454d3c03625379e39
tree176e6235e59949b0d44df9d7c2974d1ced01fa7f
parenta59fa8c13359bc96f6f76dadd9c6d1de10acbf2e
crypto: vmx - ghash: do nosimd fallback manually

VMX ghash was using a fallback that did not support interleaving simd
and nosimd operations, leading to failures in the extended test suite.

If I understood correctly, Eric's suggestion was to use the same
data format that the generic code uses, allowing us to call into it
with the same contexts. I wasn't able to get that to work - I think
there's a very different key structure and data layout being used.

So instead steal the arm64 approach and perform the fallback
operations directly if required.

Fixes: c7273208e66b ("crypto: vmx - Adding GHASH routines for VMX module")
Cc: stable@vger.kernel.org # v4.1+
Reported-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Daniel Axtens <dja@axtens.net>
Acked-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Tested-by: Michael Ellerman <mpe@ellerman.id.au>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
drivers/crypto/vmx/ghash.c