]> git.baikalelectronics.ru Git - kernel.git/commit
virtio_blk: fix race between start and stop queue
authorMing Lei <tom.leiming@gmail.com>
Fri, 16 May 2014 15:31:21 +0000 (23:31 +0800)
committerJens Axboe <axboe@fb.com>
Fri, 16 May 2014 15:40:31 +0000 (09:40 -0600)
commit816519f77c74c69020e85465a571e45b24c8a54c
treedc523b00af578c95aaf8dd34c69fc8f6ca4da208
parentf706469d41c8e432412ad10076b3b914220cbe9a
virtio_blk: fix race between start and stop queue

When there isn't enough vring descriptor for adding to vq,
blk-mq will be put as stopped state until some of pending
descriptors are completed & freed.

Unfortunately, the vq's interrupt may come just before
blk-mq's BLK_MQ_S_STOPPED flag is set, so the blk-mq will
still be kept as stopped even though lots of descriptors
are completed and freed in the interrupt handler. The worst
case is that all pending descriptors are freed in the
interrupt handler, and the queue is kept as stopped forever.

This patch fixes the problem by starting/stopping blk-mq
with holding vq_lock.

Cc: Jens Axboe <axboe@kernel.dk>
Cc: Rusty Russell <rusty@rustcorp.com.au>
Signed-off-by: Ming Lei <tom.leiming@gmail.com>
Signed-off-by: Jens Axboe <axboe@fb.com>
drivers/block/virtio_blk.c