]> git.baikalelectronics.ru Git - kernel.git/commit
mei: bus: type promotion bug in mei_nfc_if_version()
authorDan Carpenter <dan.carpenter@oracle.com>
Wed, 11 Jul 2018 12:29:31 +0000 (15:29 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 12 Jul 2018 13:44:57 +0000 (15:44 +0200)
commit81122f04b9e07c0d7b45fe4d71bf36fe81a2e51d
treef7ff799a4c9fb18411e121472f362750d890fcbe
parent4f5c2d84fb84706932d3c227f84eb03f43f741e6
mei: bus: type promotion bug in mei_nfc_if_version()

We accidentally removed the check for negative returns
without considering the issue of type promotion.
The "if_version_length" variable is type size_t so if __mei_cl_recv()
returns a negative then "bytes_recv" is type promoted
to a high positive value and treated as success.

Cc: <stable@vger.kernel.org>
Fixes: f6f528496b6d ("mei: bus: fix received data size check in NFC fixup")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/misc/mei/bus-fixup.c