]> git.baikalelectronics.ru Git - kernel.git/commit
fs/ntfs3: Fix integer overflow in ni_fiemap with fiemap_prep()
authorKari Argillander <kari.argillander@gmail.com>
Wed, 25 Aug 2021 18:24:35 +0000 (21:24 +0300)
committerKonstantin Komarov <almaz.alexandrovich@paragon-software.com>
Thu, 2 Sep 2021 15:51:00 +0000 (18:51 +0300)
commit8108b2c5db9cb01e66b0fa7f6fbb59626b5814fa
treecf9fc5b6972a8024f324aed3d02970aaa2ac962d
parent57dc6a7bdedc3f7767b04a69ed1924bd80e5661e
fs/ntfs3: Fix integer overflow in ni_fiemap with fiemap_prep()

Use fiemap_prep() to check valid flags. It also shrink request scope
(@len) to what the fs can actually handle.

This address following Smatch static checker warning:
fs/ntfs3/frecord.c:1894 ni_fiemap()
warn: potential integer overflow from user 'vbo + len'

Because fiemap_prep() shrinks @len this cannot happened anymore.

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Link: lore.kernel.org/ntfs3/20210825080440.GA17407@kili/

Fixes: bce6528b5114 ("fs/ntfs3: Add file operations and implementation")
Signed-off-by: Kari Argillander <kari.argillander@gmail.com>
Signed-off-by: Konstantin Komarov <almaz.alexandrovich@paragon-software.com>
fs/ntfs3/file.c