]> git.baikalelectronics.ru Git - kernel.git/commit
bna: ethtool: Avoid reading past end of buffer
authorKees Cook <keescook@chromium.org>
Fri, 5 May 2017 22:30:23 +0000 (15:30 -0700)
committerDavid S. Miller <davem@davemloft.net>
Mon, 8 May 2017 18:41:42 +0000 (14:41 -0400)
commit80f60b1efc76620c4f2ef3696a5ab80c59bbb0c0
tree5c7d102ae1944478185b324c19127b778ecbe896
parent6ecd03e571daad30d8292dc03cc87448f9454330
bna: ethtool: Avoid reading past end of buffer

Using memcpy() from a string that is shorter than the length copied means
the destination buffer is being filled with arbitrary data from the kernel
rodata segment. Instead, use strncpy() which will fill the trailing bytes
with zeros.

This was found with the future CONFIG_FORTIFY_SOURCE feature.

Cc: Daniel Micay <danielmicay@gmail.com>
Signed-off-by: Kees Cook <keescook@chromium.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/brocade/bna/bnad_ethtool.c